Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINDUPRULE-676 Rules for components with 1:1 matching with a Quarkus extension #516

Merged
merged 19 commits into from
Dec 14, 2020
Merged

WINDUPRULE-676 Rules for components with 1:1 matching with a Quarkus extension #516

merged 19 commits into from
Dec 14, 2020

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented Nov 5, 2020 •
edited by m-brophy
Loading

https://issues.redhat.com/browse/WINDUPRULE-676

Agreed upon reviewing 4 rulesets as the meaningful one to validate the overall PR since it's based on the same approach to generate every ruleset:

Put on hold for the review:

  • agroal
  • artemis
  • config
  • elytron
  • jdbc
  • jsonb
  • jsonp
  • keycloak
  • kubernetes-client
  • logging
  • narayana
  • openshift-client
  • resteasy

mrizzi
mrizzi commented Nov 5, 2020
View reviewed changes
Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added quarkus-amazon-lambda-xray guide's URL

rules-reviewed/quarkus/amazon/amazon-to-quarkus.windup.xml Outdated Show resolved Hide resolved
mrizzi added 13 commits November 5, 2020 19:06
@mrizzi
WINDUPRULE-676 Provided priority 1 rules
de71b02
@mrizzi
WINDUPRULE-676 Excluded 'smallrye' rules
94831fc
@mrizzi
WINDUPRULE-676 Added tests, test data and moved to 'rules-generate' f…
e28fb82 
…older
@mrizzi
WINDUPRULE-676 Create 3 different rules: project, dependency and java…
5e3760f 
…class
@mrizzi
WINDUPRULE-676 Made test JAR files creation idempotent
e9a7eaf 
Signed-off-by: mrizzi <[email protected]>
@mrizzi
WINDUPRULE-676 Added SmallRye YAML config rule
b0fd6b2 
Signed-off-by: mrizzi <[email protected]>
@mrizzi
WINDUPRULE-676 Quarkus Amazon IAM extension rule and updated link for…
08ce511 
… AWS XRay in Quarkus 1.10.2.Final
@mrizzi
WINDUPRULE-676 Quarkus quarkus-hibernate-validator extension rule
6d7b042
@mrizzi
WINDUPRULE-676 Quarkus quarkus-narayana-jta extension rule
34db66e
@mrizzi
WINDUPRULE-676 Quarkus quarkus-agroal extension rule
0aaa7d4
@mrizzi
WINDUPRULE-676 Quarkus quarkus-keycloak-admin-client extension rule
884730d
@mrizzi
WINDUPRULE-676 Quarkus quarkus-kubernetes-client extension rule
5b3a636
@mrizzi
WINDUPRULE-676 Quarkus quarkus-openshift-client extension rule
5ec59ab
mrizzi
mrizzi commented Dec 4, 2020
View reviewed changes
Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 (out of 24) generic (and to be evaluated/improved) links to be provided in rules (currently referring to https://quarkus.io/guides/)

rules-generated/quarkus/hibernate/hibernate-to-quarkus.windup.xml Outdated Show resolved Hide resolved
rules-generated/quarkus/jdbc/jdbc-to-quarkus.windup.xml Outdated Show resolved Hide resolved
rules-generated/quarkus/jsonp/jsonp-to-quarkus.windup.xml Show resolved Hide resolved
mrizzi
mrizzi commented Dec 4, 2020
View reviewed changes
Copy link
Member Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add further comments to the remaining guides' links.

rules-generated/quarkus/keycloak/keycloak-to-quarkus.windup.xml Show resolved Hide resolved
rules-generated/quarkus/resteasy/resteasy-to-quarkus.windup.xml Outdated Show resolved Hide resolved
rules-generated/quarkus/resteasy/resteasy-to-quarkus.windup.xml Outdated Show resolved Hide resolved
rules-generated/quarkus/resteasy/resteasy-to-quarkus.windup.xml Outdated Show resolved Hide resolved
rules-generated/quarkus/resteasy/resteasy-to-quarkus.windup.xml Outdated Show resolved Hide resolved
@mrizzi mrizzi requested a review from m-brophy December 10, 2020 11:17
@m-brophy m-brophy merged commit 57215f4 into windup:master Dec 14, 2020
@mrizzi mrizzi deleted the WINDUPRULE-676 branch December 14, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-brophy m-brophy m-brophy approved these changes

Assignees
No one assigned
Labels
Ready to Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrizzi @m-brophy